Ensure that pinch-zoom scrollbar animations trigger a draw

cc/trees/layer_tree_host_unittest_animation.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host.h"
 
 #include "cc/animation/animation_curve.h"
 #include "cc/animation/layer_animation_controller.h"
 #include "cc/animation/timing_function.h"
 #include "cc/layers/layer.h"
@@ skipping 747 matching lines @@
   int added_animations_;
   int started_times_;
   int finished_times_;
   FakeContentLayerClient client_;
   scoped_refptr<FakeContentLayer> content_;
 };
 
 MULTI_THREAD_TEST_F(
     LayerTreeHostAnimationTestCheckerboardDoesntStartAnimations);
 
+// Test that creating a pinch-zoom scrollbar animation leads to AnimateLayers
+// being called.
+class LayerTreeHostAnimationTestPinchZoomScrollbars
+    : public LayerTreeHostAnimationTest {
+ public:
+  LayerTreeHostAnimationTestPinchZoomScrollbars()
+      : root_layer_(ContentLayer::Create(&client_)),
+        started_times_(0),
+        num_commit_complete_(0) {}
+
+  virtual void InitializeSettings(LayerTreeSettings* settings) OVERRIDE {
+    settings->use_pinch_zoom_scrollbars = true;
+  }
+
+  virtual void SetupTree() OVERRIDE {
+    root_layer_->SetIsDrawable(true);
+    root_layer_->SetBounds(gfx::Size(100, 100));
+    layer_tree_host()->SetRootLayer(root_layer_);
+    LayerTreeHostAnimationTest::SetupTree();
+  }
+
+  virtual void BeginTest() OVERRIDE {
+    layer_tree_host()->SetPageScaleFactorAndLimits(1.55f, 1.f, 4.f);
+    PostSetNeedsCommitToMainThread();
+  }
+
+  virtual void CommitCompleteOnThread(LayerTreeHostImpl* host_impl) OVERRIDE {
+    num_commit_complete_++;
+  }
+
+  virtual void AnimateLayers(LayerTreeHostImpl* host_impl,
+                             base::TimeTicks monotonic_time) OVERRIDE {
+    // Two commits are required for the creation of pinch-zoom scrollbars.
+    // Wait for these to finish.
+    if (num_commit_complete_ < 2)
+      return;
+
+    EXPECT_NE(host_impl->active_tree()->page_scale_factor(), 1.f);
+
+    switch (started_times_) {
+      case 0:
+        host_impl->active_tree()->DidBeginScroll();
+        started_times_++;
+        break;
+      case 1:
+        host_impl->active_tree()->DidEndScroll();
+        started_times_++;
+        break;
+      case 2:
+        EndTest();
+    }
+  }
+
+  virtual void AfterTest() OVERRIDE {}
+
+ private:
+  FakeContentLayerClient client_;
+  scoped_refptr<ContentLayer> root_layer_;

[danakj, 2013/04/18 18:53:32]

Can you use FakeContentLayer here as well? Then you can skip the SetIsDrawable()
call also.

[ajuma, 2013/04/18 19:21:25]

Done.

+  int started_times_;
+  int num_commit_complete_;
+};
+
+SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostAnimationTestPinchZoomScrollbars);
+
 }  // namespace
 }  // namespace cc