Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 1401643002: Remove isolate parameter when allocating handles (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Sync Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger_api_impl.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_api_impl_test.cc
diff --git a/runtime/vm/debugger_api_impl_test.cc b/runtime/vm/debugger_api_impl_test.cc
index a090a7656ea63837b1a0208e34d5b5185361f3fd..ca260f2eedfd04edfd221264b6a26d1d7b5e5086 100644
--- a/runtime/vm/debugger_api_impl_test.cc
+++ b/runtime/vm/debugger_api_impl_test.cc
@@ -2139,6 +2139,7 @@ TEST_CASE(Debug_GetSupertype) {
"}\n";
Isolate* isolate = Isolate::Current();
+ Zone* zone = isolate->current_zone();
LoadScript(kScriptChars);
ASSERT(script_lib != NULL);
ASSERT(Dart_IsLibrary(script_lib));
@@ -2189,34 +2190,34 @@ TEST_CASE(Debug_GetSupertype) {
}
{
Dart_Handle super_type = Dart_GetSupertype(Test1_type);
- const Type& expected_type = Api::UnwrapTypeHandle(isolate, Test_type);
- const Type& actual_type = Api::UnwrapTypeHandle(isolate, super_type);
+ const Type& expected_type = Api::UnwrapTypeHandle(zone, Test_type);
+ const Type& actual_type = Api::UnwrapTypeHandle(zone, super_type);
EXPECT(expected_type.raw() == actual_type.raw());
}
{
Dart_Handle super_type = Dart_GetSupertype(Test3_type);
- const Type& expected_type = Api::UnwrapTypeHandle(isolate, Test2_int_type);
- const Type& actual_type = Api::UnwrapTypeHandle(isolate, super_type);
+ const Type& expected_type = Api::UnwrapTypeHandle(zone, Test2_int_type);
+ const Type& actual_type = Api::UnwrapTypeHandle(zone, super_type);
EXPECT(expected_type.raw() == actual_type.raw());
}
{
Dart_Handle super_type = Dart_GetSupertype(Test4_int_type);
- const Type& expected_type = Api::UnwrapTypeHandle(isolate, Test2_int_type);
- const Type& actual_type = Api::UnwrapTypeHandle(isolate, super_type);
+ const Type& expected_type = Api::UnwrapTypeHandle(zone, Test2_int_type);
+ const Type& actual_type = Api::UnwrapTypeHandle(zone, super_type);
EXPECT(expected_type.raw() == actual_type.raw());
}
{
Dart_Handle super_type = Dart_GetSupertype(Test5_int_type);
- const Type& expected_type = Api::UnwrapTypeHandle(isolate, Test4_int_type);
- const Type& actual_type = Api::UnwrapTypeHandle(isolate, super_type);
+ const Type& expected_type = Api::UnwrapTypeHandle(zone, Test4_int_type);
+ const Type& actual_type = Api::UnwrapTypeHandle(zone, super_type);
EXPECT(expected_type.raw() == actual_type.raw());
}
{
Dart_Handle set_type = Dart_GetType(core_lib, set_name, 0, NULL);
Dart_Handle super_type = Dart_GetSupertype(set_type);
Dart_Handle iterable_type = Dart_GetType(core_lib, iterable_name, 0, NULL);
- const Type& expected_type = Api::UnwrapTypeHandle(isolate, iterable_type);
- const Type& actual_type = Api::UnwrapTypeHandle(isolate, super_type);
+ const Type& expected_type = Api::UnwrapTypeHandle(zone, iterable_type);
+ const Type& actual_type = Api::UnwrapTypeHandle(zone, super_type);
EXPECT(expected_type.raw() == actual_type.raw());
}
{
« no previous file with comments | « runtime/vm/debugger_api_impl.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698