Issue 1401613005: Mac: Remove the workaround to prevent "Share" dialogs disappearing the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401613005: Mac: Remove the workaround to prevent "Share" dialogs disappearing the browser. (Closed)

Created:
5 years, 2 months ago by tapted

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mac: Remove the workaround to prevent "Share" dialogs disappearing the browser. This reverts r325166. Since Chrome now links to the 10.10 SDK, the bug that required this workaround no longer manifests. BUG=477124 TEST=(same as r325166) Click the bookmark star, right-click the (highlighted) Name. Select Share->Facebook. Click "Cancel". Browser window shouldn't mysteriously disappear.

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	chrome/browser/ui/cocoa/info_bubble_window.mm	View		1 chunk	+0 lines, -8 lines	0 comments	Download