Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 14016004: Revert 193525 (Closed)

Created:
7 years, 8 months ago by jam
Modified:
7 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 193525 I get the following when doing "gcl upload" Traceback (most recent call last): File "f:\src\depot_tools\gcl.py", line 1459, in <module> sys.exit(main(sys.argv[1:])) File "f:\src\depot_tools\gcl.py", line 1437, in main return command(argv[1:]) File "f:\src\depot_tools\gcl.py", line 1070, in CMDchange description = change_info.GetIssueDescription() AttributeError: 'ChangeInfo' object has no attribute 'GetIssueDescription' Sending crash report ... args: ['f:\\src\\depot_tools\\gcl.py', 'change', 'w4f4'] cwd: f:\src\chrome3\src exception: 'ChangeInfo' object has no attribute 'GetIssueDesc host: JABDELMALEK3-W.ad.corp.google.com stack: File "f:\src\depot_tools\gcl.py", line 1459, in user: jabdelmalek version: 2.6.2 (r262:71600, Apr 21 2009, 15:05:37) [MSC v.1 A stack trace has been sent to the maintainers. "Make gcl use git_cl.py code for consistency in th..." > Make gcl use git_cl.py code for consistency in the CL description formatting. > > This way, git_cl.py's ChangeDescription becomes the canonical CL description > handler. > > R=dpranke@chromium.org > BUG= > > Review URL: https://chromiumcodereview.appspot.com/13800018 TBR=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -48 lines) Patch
M trunk/tools/depot_tools/gcl.py View 10 chunks +44 lines, -27 lines 0 comments Download
M trunk/tools/depot_tools/tests/gcl_unittest.py View 8 chunks +15 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
7 years, 8 months ago (2013-04-11 03:13:15 UTC) #1
M-A Ruel
7 years, 8 months ago (2013-04-12 16:19:39 UTC) #2
Message was sent while issue was closed.
Thanks for reverting. I'll do the reapply on gcl so I test it at the same time.

Powered by Google App Engine
This is Rietveld 408576698