Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1401563003: Enable clear/purge for failed digests (Closed)

Created:
5 years, 2 months ago by stephana
Modified:
5 years, 2 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

This enables clearing of digests that failed to load. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/445ac3bfeeb46a776642568378150d45e505c3a3

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : WIP-adding testing to util.LRUCache #

Patch Set 5 : Rebase #

Patch Set 6 : rebase #

Patch Set 7 : Added unit test to FileDiffStore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -67 lines) Patch
M go/redisutil/redisutil_test.go View 1 2 3 2 chunks +2 lines, -53 lines 0 comments Download
M go/util/caching.go View 1 2 3 4 5 6 3 chunks +38 lines, -1 line 0 comments Download
M go/util/caching_test.go View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
A go/util/testing.go View 1 2 3 1 chunk +77 lines, -0 lines 0 comments Download
M golden/go/diff/diff.go View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M golden/go/digesttools/digesttools_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M golden/go/filediffstore/filediffstore.go View 1 2 5 chunks +105 lines, -2 lines 0 comments Download
M golden/go/filediffstore/filediffstore_test.go View 1 2 3 4 5 6 3 chunks +47 lines, -0 lines 0 comments Download
M golden/go/mocks/mocks.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M golden/go/skiacorrectness/main.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M golden/go/skiacorrectness/main2.go View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M golden/res/imp/failures-sk.html View 1 2 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
stephana
5 years, 2 months ago (2015-10-12 19:15:19 UTC) #2
jcgregorio
https://codereview.chromium.org/1401563003/diff/40001/go/util/caching.go File go/util/caching.go (right): https://codereview.chromium.org/1401563003/diff/40001/go/util/caching.go#newcode100 go/util/caching.go:100: func (m *MemLRUCache) Keys() []interface{} { Needs unit tests. ...
5 years, 2 months ago (2015-10-13 18:40:25 UTC) #3
stephana
https://codereview.chromium.org/1401563003/diff/40001/go/util/caching.go File go/util/caching.go (right): https://codereview.chromium.org/1401563003/diff/40001/go/util/caching.go#newcode100 go/util/caching.go:100: func (m *MemLRUCache) Keys() []interface{} { On 2015/10/13 18:40:24, ...
5 years, 2 months ago (2015-10-14 14:26:30 UTC) #4
jcgregorio
lgtm
5 years, 2 months ago (2015-10-14 20:38:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401563003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401563003/120001
5 years, 2 months ago (2015-10-14 21:09:25 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 21:13:02 UTC) #8
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/buildbot/+/445ac3bfeeb46a776642568378150d45e505...

Powered by Google App Engine
This is Rietveld 408576698