Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1401543002: Create a breadcrumb trail for analyzing of task model extensions. (Closed)

Created:
5 years, 2 months ago by Paul Berry
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create a breadcrumb trail for analyzing of task model extensions. This change paves the way for modifying pkg/analyzer/tool/task_dependency_graph.dart so that it will be able to understand the extensibility mechanisms in the task model. Specifically, it adds the ExtensionPointId annotation, which task_dependency_graph.dart will be able to use to locate the TaskDescriptors that are plugged into each task model extension point. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/3ae9e6228408e462ff863d59edaa74f44185ad48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 5 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
Once this lands I should be able to fix task_dependency_graph.dart so that it recognizes task ...
5 years, 2 months ago (2015-10-09 16:54:23 UTC) #2
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-09 17:53:45 UTC) #3
Paul Berry
5 years, 2 months ago (2015-10-09 18:05:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3ae9e6228408e462ff863d59edaa74f44185ad48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698