Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1401533005: Move clip property into CSSPropertyParser (Closed)

Created:
5 years, 2 months ago by rwlbuis
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move clip property into CSSPropertyParser Move clip property handling from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/b2c98d3e04afc5a1aae72dce816dfef8fffac31a Cr-Commit-Position: refs/heads/master@{#353951}

Patch Set 1 #

Patch Set 2 : Better solution #

Total comments: 1

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -52 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 3 chunks +1 line, -50 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rwlbuis
PTAL. I think the latest CL is more readable.
5 years, 2 months ago (2015-10-13 20:07:52 UTC) #2
Timothy Loh
lgtm https://codereview.chromium.org/1401533005/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1401533005/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode758 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:758: static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> consumeShape(CSSParserTokenRange& range, CSSParserMode cssParserMode) consumeShape -> ...
5 years, 2 months ago (2015-10-13 23:43:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401533005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401533005/40001
5 years, 2 months ago (2015-10-14 01:41:04 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-14 02:58:00 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 02:58:50 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b2c98d3e04afc5a1aae72dce816dfef8fffac31a
Cr-Commit-Position: refs/heads/master@{#353951}

Powered by Google App Engine
This is Rietveld 408576698