Issue 1401533004: Merge to XFA: Sanitize CJBig2_SymbolDict's memory usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401533004: Merge to XFA: Sanitize CJBig2_SymbolDict's memory usage. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Sanitize CJBig2_SymbolDict's memory usage. - Use std::vector<JBig2ArithCtx> instead of storing pointers to arrays. - Make CJBig2_SymbolDict's members private with accessors. - Use std::vector<JBig2ArithCtx> in related places. - Steal Chromium's vector_as_array() and use it as an adaptor as needed. BUG=514891 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1388203003 . (cherry picked from commit 3acb1ef909a22368507ed13817c4988c818e3aee) Committed: https://pdfium.googlesource.com/pdfium/+/5428555d7bca8116fa8c6d6914674f2c2adb17ac

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -73 lines)			Patch
M	core/src/fxcodec/jbig2/JBig2_Context.cpp	View	4 chunks	+33 lines, -39 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_SddProc.h	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_SddProc.cpp	View	8 chunks	+16 lines, -11 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_SymbolDict.h	View	2 chunks	+14 lines, -5 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_SymbolDict.cpp	View	1 chunk	+3 lines, -11 lines	0 comments	Download
M	third_party/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	third_party/base/stl_util.h	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	third_party/third_party.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 2 months ago (2015-10-09 20:57:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5428555d7bca8116fa8c6d6914674f2c2adb17ac (presubmit successful).