Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1401453002: Using RegisterConfiguration in test-multiple-return. (Closed)

Created:
5 years, 2 months ago by bradn
Modified:
5 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Using RegisterConfiguration in test-multiple-return. Not all register codes are safe for use on all architectures. Using RegisterConfiguration when picking a calling convention in test-multiple-return. BUG=None TEST=test-multiple-return R=titzer@chromium.org LOG=N Committed: https://crrev.com/5bbccc3ea3a2a11adba063fdd1254b73be0ad54f Cr-Commit-Position: refs/heads/master@{#31188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M test/cctest/compiler/test-multiple-return.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
bradn
5 years, 2 months ago (2015-10-08 22:50:02 UTC) #1
titzer
lgtm
5 years, 2 months ago (2015-10-08 22:53:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401453002/1
5 years, 2 months ago (2015-10-08 22:54:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 23:12:53 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5bbccc3ea3a2a11adba063fdd1254b73be0ad54f Cr-Commit-Position: refs/heads/master@{#31188}
5 years, 2 months ago (2015-10-08 23:13:10 UTC) #6
MTBrandyberry
5 years, 2 months ago (2015-10-09 16:01:02 UTC) #7
Message was sent while issue was closed.
On 2015/10/08 22:50:02, bradn wrote:

Thanks!

Powered by Google App Engine
This is Rietveld 408576698