Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 140143002: Revert 244973 "Roll swarming_client @ 361bfda6c0e4e2469dd3dab8c2..." (Closed)

Created:
6 years, 11 months ago by shashi
Modified:
6 years, 11 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 244973 "Roll swarming_client @ 361bfda6c0e4e2469dd3dab8c2..." > Roll swarming_client @ 361bfda6c0e4e2469dd3dab8c2b741639cacb086. > > This rolls a single important commit for read only support. > > $ git log 8cacaaaffc..361bfda6 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//' > 2014-01-15 maruel Change the default for isolate.py commands run & remap to copy files. > > TBR=vadimsh@chromium.org > BUG=116251 > > Review URL: https://codereview.chromium.org/138063007 TBR=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
shashi
6 years, 11 months ago (2014-01-15 22:14:38 UTC) #1
shashi
Committed patchset #1 manually as r244986.
6 years, 11 months ago (2014-01-15 22:14:46 UTC) #2
M-A Ruel
6 years, 11 months ago (2014-01-15 22:46:48 UTC) #3
please add the reason for the revert in the commit message next time.

What's the reason?

Sent by touching glass
Le 2014-01-15 17:14, <shashishekhar@chromium.org> a écrit :

> Reviewers: M-A Ruel,
>
> Description:
> Revert 244973 "Roll swarming_client @ 361bfda6c0e4e2469dd3dab8c2..."
>
>  Roll swarming_client @ 361bfda6c0e4e2469dd3dab8c2b741639cacb086.
>>
>
>  This rolls a single important commit for read only support.
>>
>
>  $ git log 8cacaaaffc..361bfda6 --date=short --format="%ad %ae %s" | sed
>>
> 's/@chromium\.org//'
>
>> 2014-01-15 maruel Change the default for isolate.py commands run & remap
>> to
>>
> copy files.
>
>  TBR=vadimsh@chromium.org
>> BUG=116251
>>
>
>  Review URL: https://codereview.chromium.org/138063007
>>
>
> TBR=maruel@chromium.org
>
> Please review this at https://codereview.chromium.org/140143002/
>
> SVN Base: svn://svn.chromium.org/chrome/
>
> Affected files (+1, -1 lines):
>   M     trunk/src/DEPS
>
>
> Index: trunk/src/DEPS
> ===================================================================
> --- trunk/src/DEPS      (revision 244985)
> +++ trunk/src/DEPS      (working copy)
> @@ -59,7 +59,7 @@
>    # Three lines of non-changing comments so that
>    # the commit queue can handle CLs rolling swarming_client
>    # and whatever else without interference from each other.
> -  "swarming_revision": "361bfda6c0e4e2469dd3dab8c2b741639cacb086",
> +  "swarming_revision": "8cacaaaffc0802a324a53df44a296a50db702707",
>    # Three lines of non-changing comments so that
>    # the commit queue can handle CLs rolling openssl
>    # and whatever else without interference from each other.
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698