ui/gl/gl_image_stub.h - Issue 1401423003: Re-land: ui: Move GLImage::BindTexImage fallback from GLImage implementations to GLES2CmdDecoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_image_stub.h

Issue 1401423003: Re-land: ui: Move GLImage::BindTexImage fallback from GLImage implementations to GLES2CmdDecoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gl/gl_image_stub.h

diff --git a/ui/gl/gl_image_stub.h b/ui/gl/gl_image_stub.h

index be31bff5afcb48f4bcc38b7cfdb330d9a79f6692..21f14622931f6ab1af93481cffa050f75fc5a858 100644

--- a/ui/gl/gl_image_stub.h

+++ b/ui/gl/gl_image_stub.h

@@ -16,10 +16,11 @@ class GL_EXPORT GLImageStub : public GLImage {

// Overridden from GLImage:

void Destroy(bool have_context) override {}

- gfx::Size GetSize() override;

+ Size GetSize() override;

unsigned GetInternalFormat() override;

bool BindTexImage(unsigned target) override;

void ReleaseTexImage(unsigned target) override {}

+ bool CopyTexImage(unsigned target) override;

bool CopyTexSubImage(unsigned target,

const Point& offset,

const Rect& rect) override;

@@ -27,7 +28,7 @@ class GL_EXPORT GLImageStub : public GLImage {

void DidUseTexImage() override {}

void WillModifyTexImage() override {}

void DidModifyTexImage() override {}

- bool ScheduleOverlayPlane(gfx::AcceleratedWidget widget,

+ bool ScheduleOverlayPlane(AcceleratedWidget widget,

int z_order,

OverlayTransform transform,

const Rect& bounds_rect,

« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « ui/gl/gl_image_shared_memory_unittest.cc ('k') | ui/gl/gl_image_stub.cc » ('j') | no next file with comments »