Re-land: ui: Move GLImage::BindTexImage fallback from GLImage implementations to GLES2CmdDecoder.

gpu/command_buffer/service/stream_texture_manager_in_process_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/stream_texture_manager_in_process_android.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "gpu/command_buffer/service/texture_manager.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gl/android/surface_texture.h"
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_image.h"
 
 namespace gpu {
 
 namespace {
 
 // Simply wraps a SurfaceTexture reference as a GLImage.
 class GLImageImpl : public gfx::GLImage {
  public:
-  GLImageImpl(const scoped_refptr<gfx::SurfaceTexture>& surface_texture,
+  GLImageImpl(gles2::TextureRef* texture_ref,
+              const scoped_refptr<gfx::SurfaceTexture>& surface_texture,
               const base::Closure& release_callback);
 
   // implement gfx::GLImage
   void Destroy(bool have_context) override;
   gfx::Size GetSize() override;
   unsigned GetInternalFormat() override;
   bool BindTexImage(unsigned target) override;
   void ReleaseTexImage(unsigned target) override;
+  bool CopyTexImage(unsigned target) override;
   bool CopyTexSubImage(unsigned target,
                        const gfx::Point& offset,
                        const gfx::Rect& rect) override;
-  void WillUseTexImage() override;
-  void DidUseTexImage() override {}
-  void WillModifyTexImage() override {}
-  void DidModifyTexImage() override {}
   bool ScheduleOverlayPlane(gfx::AcceleratedWidget widget,
                             int z_order,
                             gfx::OverlayTransform transform,
                             const gfx::Rect& bounds_rect,
                             const gfx::RectF& crop_rect) override;
   void OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd,
                     uint64_t process_tracing_id,
                     const std::string& dump_name) override;
 
  private:
   ~GLImageImpl() override;
 
+  gles2::TextureRef* texture_ref_;
   scoped_refptr<gfx::SurfaceTexture> surface_texture_;
   base::Closure release_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(GLImageImpl);
 };
 
 GLImageImpl::GLImageImpl(
+    gles2::TextureRef* texture_ref,
     const scoped_refptr<gfx::SurfaceTexture>& surface_texture,
     const base::Closure& release_callback)
-    : surface_texture_(surface_texture), release_callback_(release_callback) {}
+    : texture_ref_(texture_ref),
+      surface_texture_(surface_texture),
+      release_callback_(release_callback) {}
 
 GLImageImpl::~GLImageImpl() {
   release_callback_.Run();
 }
 
 void GLImageImpl::Destroy(bool have_context) {
   NOTREACHED();
 }
 
 gfx::Size GLImageImpl::GetSize() {
   return gfx::Size();
 }
 
 unsigned GLImageImpl::GetInternalFormat() {
   return GL_RGBA;
 }
 
 bool GLImageImpl::BindTexImage(unsigned target) {
   NOTREACHED();
   return false;
 }
 
 void GLImageImpl::ReleaseTexImage(unsigned target) {
   NOTREACHED();
 }
 
+bool GLImageImpl::CopyTexImage(unsigned target) {
+  surface_texture_->UpdateTexImage();
+
+  // By setting image state to UNBOUND instead of COPIED we ensure that
+  // CopyTexImage() is called each time the surface texture is used for
+  // drawing.
+  texture_ref_->texture()->SetLevelImage(GL_TEXTURE_EXTERNAL_OES, 0, this,
+                                         gles2::Texture::UNBOUND);
+  return true;
+}
+
 bool GLImageImpl::CopyTexSubImage(unsigned target,
                                   const gfx::Point& offset,
                                   const gfx::Rect& rect) {
   return false;
 }
 
-void GLImageImpl::WillUseTexImage() {
-  surface_texture_->UpdateTexImage();
-}
-
 bool GLImageImpl::ScheduleOverlayPlane(gfx::AcceleratedWidget widget,
                                        int z_order,
                                        gfx::OverlayTransform transform,
                                        const gfx::Rect& bounds_rect,
                                        const gfx::RectF& crop_rect) {
   NOTREACHED();
   return false;
 }
 
 void GLImageImpl::OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd,
@@ skipping 26 matching lines @@
     return 0;
   }
 
   scoped_refptr<gfx::SurfaceTexture> surface_texture(
       gfx::SurfaceTexture::Create(texture->service_id()));
 
   uint32 stream_id = next_id_++;
   base::Closure release_callback =
       base::Bind(&StreamTextureManagerInProcess::OnReleaseStreamTexture,
                  weak_factory_.GetWeakPtr(), stream_id);
-  scoped_refptr<gfx::GLImage> gl_image(new GLImageImpl(surface_texture,
-                                       release_callback));
+  scoped_refptr<gfx::GLImage> gl_image(
+      new GLImageImpl(texture, surface_texture, release_callback));
 
   gfx::Size size = gl_image->GetSize();
   texture_manager->SetTarget(texture, GL_TEXTURE_EXTERNAL_OES);
   texture_manager->SetLevelInfo(texture, GL_TEXTURE_EXTERNAL_OES, 0, GL_RGBA,
                                 size.width(), size.height(), 1, 0, GL_RGBA,
                                 GL_UNSIGNED_BYTE, gfx::Rect(size));
-  texture_manager->SetLevelImage(
-      texture, GL_TEXTURE_EXTERNAL_OES, 0, gl_image.get());
+  texture_manager->SetLevelImage(texture, GL_TEXTURE_EXTERNAL_OES, 0,
+                                 gl_image.get(), gles2::Texture::UNBOUND);
 
   {
     base::AutoLock lock(map_lock_);
     textures_[stream_id] = surface_texture;
   }
 
   if (next_id_ == 0)
     next_id_++;
 
   return stream_id;
@@ skipping 10 matching lines @@
 StreamTextureManagerInProcess::GetSurfaceTexture(uint32 stream_id) {
   base::AutoLock lock(map_lock_);
   TextureMap::const_iterator it = textures_.find(stream_id);
   if (it != textures_.end())
     return it->second;
 
   return NULL;
 }
 
 }  // namespace gpu