Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: runtime/vm/dart_api_impl.h

Issue 1401413002: Move no_callback_scope_depth_ and cha_ from isolate -> thread (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Spelling fix Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.h
diff --git a/runtime/vm/dart_api_impl.h b/runtime/vm/dart_api_impl.h
index a1bb236070374a7eeaaba7309df0c2a944ad3c86..613778a93f305b30b15be5a15033d435d2f1b711 100644
--- a/runtime/vm/dart_api_impl.h
+++ b/runtime/vm/dart_api_impl.h
@@ -304,16 +304,17 @@ class IsolateSaver {
};
// Start a scope in which no Dart API call backs are allowed.
-#define START_NO_CALLBACK_SCOPE(isolate) \
- isolate->IncrementNoCallbackScopeDepth()
+#define START_NO_CALLBACK_SCOPE(thread) \
+ thread->IncrementNoCallbackScopeDepth()
// End a no Dart API call backs Scope.
-#define END_NO_CALLBACK_SCOPE(isolate) \
- isolate->DecrementNoCallbackScopeDepth()
+#define END_NO_CALLBACK_SCOPE(thread) \
+ thread->DecrementNoCallbackScopeDepth()
-#define CHECK_CALLBACK_STATE(isolate) \
- if (isolate->no_callback_scope_depth() != 0) { \
- return reinterpret_cast<Dart_Handle>(Api::AcquiredError(isolate)); \
+#define CHECK_CALLBACK_STATE(thread) \
+ if (thread->no_callback_scope_depth() != 0) { \
+ return reinterpret_cast<Dart_Handle>( \
+ Api::AcquiredError(thread->isolate())); \
} \
#define CHECK_COMPILATION_ALLOWED(isolate) \
@@ -322,8 +323,8 @@ class IsolateSaver {
CURRENT_FUNC); \
} \
-#define ASSERT_CALLBACK_STATE(isolate) \
- ASSERT(isolate->no_callback_scope_depth() == 0)
+#define ASSERT_CALLBACK_STATE(thread) \
+ ASSERT(thread->no_callback_scope_depth() == 0)
} // namespace dart.
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698