Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1401413002: Move no_callback_scope_depth_ and cha_ from isolate -> thread (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move no_callback_scope_depth_ and cha_ from isolate -> thread Add checks for background compilation: - Dart code may not be invoked - Object allocation must happen in old space BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ab20fa00dab7d36d5236c7fb3100b6ef44b51c89

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : Spelling fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -117 lines) Patch
M runtime/vm/base_isolate.h View 2 chunks +1 line, -17 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 3 chunks +12 lines, -13 lines 0 comments Download
M runtime/vm/dart_api_impl.h View 2 chunks +10 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 56 chunks +63 lines, -65 lines 0 comments Download
M runtime/vm/dart_entry.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/isolate.h View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/mirrors_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/native_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/thread.h View 2 chunks +18 lines, -2 lines 0 comments Download
M runtime/vm/thread.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 2 months ago (2015-10-13 20:14:11 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1401413002/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1401413002/diff/20001/runtime/vm/compiler.cc#newcode1483 runtime/vm/compiler.cc:1483: // unotpimized code. unoptimized
5 years, 2 months ago (2015-10-13 20:47:56 UTC) #3
srdjan
Committed patchset #3 (id:40001) manually as ab20fa00dab7d36d5236c7fb3100b6ef44b51c89 (presubmit successful).
5 years, 2 months ago (2015-10-13 21:29:57 UTC) #4
srdjan
5 years, 2 months ago (2015-10-14 18:27:45 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1401413002/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1401413002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1483: // unotpimized code.
On 2015/10/13 20:47:55, rmacnak wrote:
> unoptimized

Done.

Powered by Google App Engine
This is Rietveld 408576698