Issue 1401403006: Use new task model in completion tests [TBR].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401403006: Use new task model in completion tests [TBR]. (Closed)

Created:
5 years, 2 months ago by pquitslund

Modified:
5 years, 2 months ago

Reviewers:
scheglov, danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use new task model in completion tests. Committed: https://github.com/dart-lang/sdk/commit/0cd0c886a102f7a17f23ff372c51bc65beb86ced Another TBR in the quest for greenness.

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	pkg/analysis_server/test/domain_completion_test.dart	View		3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pquitslund

Committed patchset #1 (id:1) manually as 0cd0c886a102f7a17f23ff372c51bc65beb86ced (presubmit successful).

5 years, 2 months ago (2015-10-15 05:29:58 UTC) #1

Brian Wilkerson

I'll defer to Dan, but this looks suspicious to me.

5 years, 2 months ago (2015-10-15 13:56:18 UTC) #6

pquitslund

5 years, 2 months ago (2015-10-15 15:41:09 UTC) #7

Message was sent while issue was closed.

On 2015/10/15 13:56:18, Brian Wilkerson wrote:
> I'll defer to Dan, but this looks suspicious to me.

Dan?

If nothing else this highlights how intertwined these bits are.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages