Issue 1401403005: More extension manager unification [TBR]. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(230)

My Issues | Starred Open | Closed | All

Issue 1401403005: More extension manager unification [TBR]. (Closed)

Created:
5 years, 2 months ago by pquitslund

Modified:
5 years, 2 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

More extension manager unification. Addresses bot test failures: http://build.chromium.org/p/client.dart/builders/pkg-mac-be/builds/1531/steps/pkg%20%20tests%20failures/logs/stdio. (See https://codereview.chromium.org/1398033004/ for background.) Marking TBR in quest for build greenness. Committed: https://github.com/dart-lang/sdk/commit/3188a749946e62f335914691b5a7198662b3648a

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	pkg/analysis_server/test/analysis_server_test.dart	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pquitslund

Committed patchset #1 (id:1) manually as 3188a749946e62f335914691b5a7198662b3648a (presubmit successful).

5 years, 2 months ago (2015-10-15 04:22:31 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698