Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1401283003: Supply separate flags for onBuildTileIndex (Closed)

Created:
5 years, 2 months ago by scroggo
Modified:
5 years, 2 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Supply separate flags for onBuildTileIndex Since png and jpeg's implementations of onBuildTileIndex rely on modifications to their underlying libraries, rather than whether we are running on Android, use separate flags that can be disabled independently. This will allow us to easily turn off the feature. It also is a step towards building and running on other platforms for testing (e.g. valgrind/ASAN to find memory leaks etc). Committed: https://skia.googlesource.com/skia/+/8e48ed51baf0099d0a279474f6fc01a3ab857d60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M src/images/SkImageDecoder_libjpeg.cpp View 8 chunks +11 lines, -7 lines 0 comments Download
M src/images/SkImageDecoder_libpng.cpp View 5 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scroggo
This may make the switchover a little easier. On the other hand, we could just ...
5 years, 2 months ago (2015-10-13 20:34:50 UTC) #2
msarett
lgtm
5 years, 2 months ago (2015-10-13 22:04:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401283003/1
5 years, 2 months ago (2015-10-14 14:24:03 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 14:54:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8e48ed51baf0099d0a279474f6fc01a3ab857d60

Powered by Google App Engine
This is Rietveld 408576698