Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: lib/src/server/server.dart

Issue 1401273002: Move DDC to analyzer-based checker (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/info.dart ('k') | lib/src/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/server/server.dart
diff --git a/lib/src/server/server.dart b/lib/src/server/server.dart
index 9a6320f85efa5f5de52d0a1e54eac979686a74cb..079b2311d43dbdadbe34063568cfa21ddb808918 100644
--- a/lib/src/server/server.dart
+++ b/lib/src/server/server.dart
@@ -84,7 +84,7 @@ class ServerCompiler extends AbstractCompiler {
var time = (clock.elapsedMilliseconds / 1000).toStringAsFixed(2);
_log.fine('Compiled ${_libraries.length} libraries in ${time} s\n');
return new CheckerResults(
- _libraries, rules, _failure || options.codegenOptions.forceCompile);
+ _libraries, _failure || options.codegenOptions.forceCompile);
}
bool _buildSource(SourceNode node) {
@@ -154,9 +154,7 @@ class ServerCompiler extends AbstractCompiler {
for (var unit in libraryUnit.libraryThenParts) {
var unitSource = unit.element.source;
// TODO(sigmund): integrate analyzer errors with static-info (issue #6).
- failureInLib = logErrors(unitSource) || failureInLib;
- checker.visitCompilationUnit(unit);
- if (checker.failure) failureInLib = true;
+ failureInLib = computeErrors(unitSource) || failureInLib;
}
if (failureInLib) {
_failure = true;
@@ -310,4 +308,4 @@ class _ExistingSourceUriResolver implements UriResolver {
}
final _log = new Logger('dev_compiler.src.server');
-final _earlyErrorResult = new CheckerResults(const [], null, true);
+final _earlyErrorResult = new CheckerResults(const [], true);
« no previous file with comments | « lib/src/info.dart ('k') | lib/src/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698