Issue 1401253004: Cleanup the extensions code to avoid the duplication that was introduced in the quick fix to turn t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401253004: Cleanup the extensions code to avoid the duplication that was introduced in the quick fix to turn t… (Closed)

Created:
5 years, 2 months ago by siva

Modified:
5 years, 2 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Cleanup the extensions code to avoid the duplication that was introduced in the quick fix to turn the bots green. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b4d0ca282dbde48728e3b4620c8d2e9f085829f6

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -107 lines)			Patch
M	runtime/bin/extensions.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	runtime/bin/extensions.cc	View	1 chunk	+5 lines, -7 lines	0 comments	Download
M	runtime/bin/extensions_android.cc	View	2 chunks	+6 lines, -24 lines	0 comments	Download
M	runtime/bin/extensions_linux.cc	View	2 chunks	+6 lines, -24 lines	0 comments	Download
M	runtime/bin/extensions_macos.cc	View	2 chunks	+6 lines, -24 lines	0 comments	Download
M	runtime/bin/extensions_win.cc	View	2 chunks	+9 lines, -23 lines	0 comments	Download

Total messages: 4 (1 generated)

siva

5 years, 2 months ago (2015-10-14 22:28:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b4d0ca282dbde48728e3b4620c8d2e9f085829f6 (presubmit successful).