Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 1401253003: Check for let in lexically bound names for short object literals (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check for let in lexically bound names for short object literals An identifier may be parsed in an object literal like {let}, but this was previously left out of lexical name checking. This patch adds that check to prohibit code like let {let} = {let: 1} BUG=v8:4403 LOG=N R=adamk Committed: https://crrev.com/dd24cc33d3c26ef5548efe7967d880cd56b98278 Cr-Commit-Position: refs/heads/master@{#31278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/preparser.h View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/message/let-lexical-name-in-object-prohibited.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/message/let-lexical-name-in-object-prohibited.out View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dan Ehrenberg
5 years, 2 months ago (2015-10-14 16:32:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401253003/1
5 years, 2 months ago (2015-10-14 16:32:37 UTC) #3
adamk
lgtm
5 years, 2 months ago (2015-10-14 16:35:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 17:34:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401253003/1
5 years, 2 months ago (2015-10-15 07:51:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 07:52:17 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 07:52:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd24cc33d3c26ef5548efe7967d880cd56b98278
Cr-Commit-Position: refs/heads/master@{#31278}

Powered by Google App Engine
This is Rietveld 408576698