Issue 1401233002: Fixed wrap_jso recursive calls - now rely on Utils_constructor_create to call setDartHtmlWrapper pr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401233002: Fixed wrap_jso recursive calls - now rely on Utils_constructor_create to call setDartHtmlWrapper pr… (Closed)

Created:
5 years, 2 months ago by terry

Modified:
5 years, 2 months ago

Reviewers:
Alan Knight, Jacob

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fixed wrap_jso recursive calls - now rely on Utils_constructor_create to call setDartHtmlWrapper prior to calling the created constructor. TBR=jacobr@google.com,alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/ad8ed17bb86e378217d7943f8d0e091c10332d4c

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -35 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -17 lines	0 comments	Download
M	tools/deps/dartium.deps/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1 chunk	+1 line, -17 lines	0 comments	Download

Total messages: 2 (0 generated)

terry

Committed patchset #1 (id:1) manually as ad8ed17bb86e378217d7943f8d0e091c10332d4c (presubmit successful).

5 years, 2 months ago (2015-10-12 20:56:35 UTC) #1

Message was sent while issue was closed.

lgtm