Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1401173006: Add new bench to compare drawSprite() and drawBitmap(). (Closed)

Created:
5 years, 2 months ago by Stephen White
Modified:
5 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add new bench to compare drawSprite() and drawBitmap(). Currently, drawSprite() is faster when an image filter is attached. BUG=skia:1062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
A bench/ImageFilterSpriteVsBitmap.cpp View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Stephen White
reed@: PTAL. Thanks!
5 years, 2 months ago (2015-10-14 16:53:10 UTC) #2
Stephen White
On 2015/10/14 16:53:10, Stephen White wrote: > reed@: PTAL. Thanks! mtklein: I've just realized this ...
5 years, 2 months ago (2015-10-14 16:56:56 UTC) #3
mtklein
On 2015/10/14 16:56:56, Stephen White wrote: > On 2015/10/14 16:53:10, Stephen White wrote: > > ...
5 years, 2 months ago (2015-10-14 17:00:51 UTC) #4
reed1
With applyFilter (once we have a gpu-version of colorfilterimagefilter), there will be no callers of ...
5 years, 2 months ago (2015-10-14 19:33:01 UTC) #5
Stephen White
On 2015/10/14 19:33:01, reed1 wrote: > With applyFilter (once we have a gpu-version of colorfilterimagefilter), ...
5 years, 2 months ago (2015-10-14 19:36:51 UTC) #6
Stephen White
reed@: Could we land the drawBitmap() part of this, at a minimum? It would be ...
5 years, 2 months ago (2015-10-15 03:13:56 UTC) #7
Stephen White
5 years ago (2015-12-07 21:02:29 UTC) #8
Closing this in favour of reed@'s https://codereview.chromium.org/1497843003
which has already landed.

Powered by Google App Engine
This is Rietveld 408576698