Issue 140113002: Fix memory leak in readingListPrivate api test.

Issue 140113002: Fix memory leak in readingListPrivate api test. (Closed)

Created:
6 years, 11 months ago by Yaron

Modified:
6 years, 11 months ago

Reviewers:
nyquist, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix memory leak in readingListPrivate api test. FakeDB::EntryMap wasn't getting cleaned up in the test. Changed the API to make it clearer that ownership isn't taken. BUG=334682 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245282

Patch Set 1 #

Total comments: 1

Patch Set 2 : inline #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
M	chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	components/dom_distiller/core/dom_distiller_service_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/dom_distiller/core/dom_distiller_store_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/dom_distiller/core/dom_distiller_test_util.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/dom_distiller/core/dom_distiller_test_util.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm for extensions https://codereview.chromium.org/140113002/diff/1/chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc File chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc (right): https://codereview.chromium.org/140113002/diff/1/chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc#newcode30 chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc:30: FakeDB::EntryMap store_model; (consider inlining)

6 years, 11 months ago (2014-01-15 22:10:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/140113002/80001

6 years, 11 months ago (2014-01-15 22:55:09 UTC) #4

Message was sent while issue was closed.

Change committed as 245282

Expand Messages | Collapse Messages