Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6830)

Unified Diff: chrome/browser/permissions/permission_context_uma_util.h

Issue 1401073002: Add Rappor reporting for grant/deny/cancel/ignore of Mediastream permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use existing rappor code Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_uma_util.h
diff --git a/chrome/browser/permissions/permission_context_uma_util.h b/chrome/browser/permissions/permission_context_uma_util.h
index d4c362b4896d9f16af1541650ed8262f63a87c18..298770e77f7d01b42ac914b63e809836f4fa0dfb 100644
--- a/chrome/browser/permissions/permission_context_uma_util.h
+++ b/chrome/browser/permissions/permission_context_uma_util.h
@@ -11,6 +11,22 @@
class GURL;
class Profile;
+// Enum for UMA purposes, make sure you update histograms.xml if you add new
+// permission actions. Never delete or reorder an entry; only add new entries
+// immediately before PERMISSION_NUM
+enum PermissionAction {
+ GRANTED = 0,
+ DENIED = 1,
+ DISMISSED = 2,
+ IGNORED = 3,
+ REVOKED = 4,
+ REENABLED = 5,
+ REQUESTED = 6,
+
+ // Always keep this at the end.
+ PERMISSION_ACTION_NUM,
+};
+
// Provides a convenient way of logging UMA for permission related
// operations.
class PermissionContextUmaUtil {
@@ -28,6 +44,9 @@ class PermissionContextUmaUtil {
static void PermissionIgnored(ContentSettingsType permission,
const GURL& requesting_origin);
static const std::string GetPermissionString(ContentSettingsType permission);
+ static void RecordMultiDRapporAction(ContentSettingsType permission,
+ const GURL& requesting_origin,
+ PermissionAction action);
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionContextUmaUtil);

Powered by Google App Engine
This is Rietveld 408576698