Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: chrome/browser/permissions/permission_context_uma_util.cc

Issue 1401073002: Add Rappor reporting for grant/deny/cancel/ignore of Mediastream permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_uma_util.cc
diff --git a/chrome/browser/permissions/permission_context_uma_util.cc b/chrome/browser/permissions/permission_context_uma_util.cc
index 8a917559ffd9df6604b072a22a3ab4b61a434c2b..17cf35acd8ee87d188cd9c236a93291a9fd899b5 100644
--- a/chrome/browser/permissions/permission_context_uma_util.cc
+++ b/chrome/browser/permissions/permission_context_uma_util.cc
@@ -32,22 +32,6 @@ using content::PermissionType;
namespace {
-// Enum for UMA purposes, make sure you update histograms.xml if you add new
-// permission actions. Never delete or reorder an entry; only add new entries
-// immediately before PERMISSION_NUM
-enum PermissionAction {
- GRANTED = 0,
- DENIED = 1,
- DISMISSED = 2,
- IGNORED = 3,
- REVOKED = 4,
- REENABLED = 5,
- REQUESTED = 6,
-
- // Always keep this at the end.
- PERMISSION_ACTION_NUM,
-};
-
// The returned strings must match the RAPPOR metrics in rappor.xml,
// e.g. Permissions.Action.Geolocation etc..
const std::string GetPermissionString(ContentSettingsType permission) {

Powered by Google App Engine
This is Rietveld 408576698