Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: net/quic/quic_protocol.h

Issue 1401053005: relnote: Reduce the size of QUIC's TransmissionInfo struct based on (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_test_cases_to_catch_failure_104130818
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_protocol.h
diff --git a/net/quic/quic_protocol.h b/net/quic/quic_protocol.h
index 50c1d441ea5afd92c7929f3763dfc03d6fdab3ba..eb80b7d39b710df8184ede173fcf97aa370d4132 100644
--- a/net/quic/quic_protocol.h
+++ b/net/quic/quic_protocol.h
@@ -51,6 +51,7 @@ typedef std::map<QuicTag, std::string> QuicTagValueMap;
// TODO(rtenneti): Didn't use SpdyPriority because SpdyPriority is uint8 and
// QuicPriority is uint32. Use SpdyPriority when we change the QUIC_VERSION.
typedef uint32 QuicPriority;
+typedef uint16 QuicPacketLength;
// Default initial maximum size in bytes of a QUIC packet.
const QuicByteCount kDefaultMaxPacketSize = 1350;
@@ -1184,25 +1185,25 @@ struct NET_EXPORT_PRIVATE TransmissionInfo {
QuicPacketNumberLength packet_number_length,
TransmissionType transmission_type,
QuicTime sent_time,
- QuicByteCount bytes_sent,
+ QuicPacketLength bytes_sent,
bool is_fec_packet);
RetransmittableFrames* retransmittable_frames;
QuicPacketNumberLength packet_number_length;
+ QuicPacketLength bytes_sent;
+ uint16 nack_count;
QuicTime sent_time;
- QuicByteCount bytes_sent;
- QuicPacketCount nack_count;
// Reason why this packet was transmitted.
TransmissionType transmission_type;
- // Stores the packet numbers of all transmissions of this packet.
- // Must always be nullptr or have multiple elements.
- PacketNumberList* all_transmissions;
// In flight packets have not been abandoned or lost.
bool in_flight;
// True if the packet can never be acked, so it can be removed.
bool is_unackable;
// True if the packet is an FEC packet.
bool is_fec_packet;
+ // Stores the packet numbers of all transmissions of this packet.
+ // Must always be nullptr or have multiple elements.
+ PacketNumberList* all_transmissions;
};
// Convenience wrapper to wrap an iovec array and the total length, which must
« no previous file with comments | « no previous file | net/quic/quic_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698