Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1401053002: Make ProcessCurrentUrl() and OnFaviconDataForInitialURLFromFaviconService() share code (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@page_changed_under_us
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ProcessCurrentUrl() and OnFaviconDataForInitialURLFromFaviconService() share code BUG=542057 Committed: https://crrev.com/1f7970b41da80c93d0fee33becbafceeb6ef55ad Cr-Commit-Position: refs/heads/master@{#354520}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -40 lines) Patch
M components/favicon/core/favicon_handler.h View 2 chunks +8 lines, -8 lines 0 comments Download
M components/favicon/core/favicon_handler.cc View 3 chunks +19 lines, -32 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
pkotwicz
Scott, can you please take a look? This is a refactoring only CL and should ...
5 years, 2 months ago (2015-10-11 20:24:35 UTC) #2
sky
LGTM
5 years, 2 months ago (2015-10-12 19:07:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401053002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401053002/80001
5 years, 2 months ago (2015-10-16 15:14:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:80001)
5 years, 2 months ago (2015-10-16 15:58:21 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 15:59:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f7970b41da80c93d0fee33becbafceeb6ef55ad
Cr-Commit-Position: refs/heads/master@{#354520}

Powered by Google App Engine
This is Rietveld 408576698