Issue 1400993002: ninja win: Suppress noisy messages from link.exe when LTCG is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1400993002: ninja win: Suppress noisy messages from link.exe when LTCG is enabled (Closed)

Created:
5 years, 2 months ago by yukawa

Modified:
5 years, 2 months ago

Reviewers:
Nico, scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp@master

Target Ref:
refs/heads/master

Project:
gyp

Visibility:
Public.

ninja win: Suppress noisy messages from link.exe when LTCG is enabled When LTCG is enabled, link.exe emits noise like: " Generating code Finished generating code " With this CL, win_tool.py drains those noisy messages to keep the console clean in successfull builds. BUG=gyp:500 TEST=unittest R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/c3d861c8bca42f942e829b77b0886275ae0a40b8

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	pylib/gyp/win_tool.py	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	test/win/gyptest-link-ltcg.py	View		2 chunks	+9 lines, -1 line	0 comments	Download

Total messages: 6 (3 generated)

yukawa

Can you take a look? Would be great if we can eliminate noisy messages like ...

5 years, 2 months ago (2015-10-10 21:36:37 UTC) #4

yukawa

5 years, 2 months ago (2015-10-12 18:54:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:40001) manually as
c3d861c8bca42f942e829b77b0886275ae0a40b8 (presubmit successful).