Issue 140093007: [NaCl SDK AppEngine] Add a fullscreen bullet demo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140093007: [NaCl SDK AppEngine] Add a fullscreen bullet demo. (Closed)

Created:
6 years, 10 months ago by binji

Modified:
6 years, 10 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, binji, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK AppEngine] Add a fullscreen bullet demo. The fullscreen view moves the controls to a panel in the upper-left, and removes most of the text. Also, fix some flexbox bugs that only appear in Chrome 34 (not Chrome 32). It seems that the flex-shrink attribute needs to be 1 now, or the element will use more than its desired size, even if flex-grow is 0. Not sure if this is a bug or not... BUG=341666 R=sbc@chromium.org

Patch Set 1 #

Patch Set 2 : 2014 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+207 lines, -2 lines)			Patch
	A	native_client_sdk/src/gonacl_appengine/static/bullet/fullscreen.html	View	1	1 chunk	+205 lines, -0 lines	0 comments	Download
	M	native_client_sdk/src/gonacl_appengine/static/styles/style.css	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

6 years, 10 months ago (2014-02-18 20:44:08 UTC) #3

LGTM, although my knowledge of html/css is not really enough to give in-depth
feedback.

Expand Messages | Collapse Messages