Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: components/autofill/content/renderer/page_click_listener.h

Issue 140093005: Add supports that allow Autofill to be initiated from textarea field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update codes as per Ilya's 2nd set comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/page_click_listener.h
diff --git a/components/autofill/content/renderer/page_click_listener.h b/components/autofill/content/renderer/page_click_listener.h
index 1fc7862fe9e29796e6b547483345928494d50b4a..758c737a07069959c3db34f2f13b3985fb6bd49b 100644
--- a/components/autofill/content/renderer/page_click_listener.h
+++ b/components/autofill/content/renderer/page_click_listener.h
@@ -6,7 +6,7 @@
#define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PAGE_CLICK_LISTENER_H_
namespace blink {
-class WebInputElement;
+class WebFormControlElement;
}
namespace autofill {
@@ -19,13 +19,13 @@ class PageClickListener {
// Notification that |element| was clicked.
// |was_focused| is true if |element| had focus BEFORE the click.
// |is_focused| is true if |element| has focus AFTER the click was processed.
- virtual void InputElementClicked(const blink::WebInputElement& element,
- bool was_focused,
- bool is_focused) = 0;
+ virtual void FormControlElementClicked(
+ const blink::WebFormControlElement& element,
+ bool was_focused) = 0;
- // If the previously focused element was an input field, listeners are
- // informed that the text field has lost its focus.
- virtual void InputElementLostFocus() = 0;
+ // If the previously focused element was an input field or a textarea field,
Ilya Sherman 2014/02/26 00:12:07 nit: "textarea field" -> "textarea"
ziran.sun 2014/02/26 18:11:50 Done.
+ // listeners are informed that the text field has lost its focus.
+ virtual void FormControlElementLostFocus() = 0;
protected:
virtual ~PageClickListener() {}

Powered by Google App Engine
This is Rietveld 408576698