Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 140093005: Add supports that allow Autofill to be initiated from textarea field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update codes as per Ilya's 2nd set comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index cb4df0317f580c4c423bf3eae2749a7278ddb4e1..5a3f4192f255196a8dc7a44739cc1efa5a487ca3 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -18,8 +18,10 @@
#include "components/autofill/core/common/forms_seen_state.h"
#include "content/public/renderer/render_view_observer.h"
#include "third_party/WebKit/public/web/WebAutofillClient.h"
+#include "third_party/WebKit/public/web/WebFormControlElement.h"
#include "third_party/WebKit/public/web/WebFormElement.h"
#include "third_party/WebKit/public/web/WebInputElement.h"
+#include "third_party/WebKit/public/web/WebTextAreaElement.h"
Ilya Sherman 2014/02/26 00:12:07 nit: Doesn't look like this is needed.
ziran.sun 2014/02/26 18:11:50 Done.
namespace blink {
class WebNode;
@@ -75,16 +77,20 @@ class AutofillAgent : public content::RenderViewObserver,
virtual void OrientationChangeEvent(int orientation) OVERRIDE;
// PageClickListener:
- virtual void InputElementClicked(const blink::WebInputElement& element,
- bool was_focused,
- bool is_focused) OVERRIDE;
- virtual void InputElementLostFocus() OVERRIDE;
+ virtual void FormControlElementClicked(
+ const blink::WebFormControlElement& element,
+ bool was_focused) OVERRIDE;
+ virtual void FormControlElementLostFocus() OVERRIDE;
// blink::WebAutofillClient:
virtual void textFieldDidEndEditing(
const blink::WebInputElement& element) OVERRIDE;
+ // TODO(ziran.sun): To be removed once next Blink roll is done
virtual void textFieldDidChange(
- const blink::WebInputElement& element) OVERRIDE;
+ const blink::WebInputElement& element);
+ // TODO(ziran.sun): OVERRIDE this function once next Blink roll is done
+ virtual void textFieldDidChange(
+ const blink::WebFormControlElement& element);
virtual void textFieldDidReceiveKeyDown(
const blink::WebInputElement& element,
const blink::WebKeyboardEvent& event) OVERRIDE;
@@ -124,7 +130,7 @@ class AutofillAgent : public content::RenderViewObserver,
// Called in a posted task by textFieldDidChange() to work-around a WebKit bug
// http://bugs.webkit.org/show_bug.cgi?id=16976
- void TextFieldDidChangeImpl(const blink::WebInputElement& element);
+ void TextFieldDidChangeImpl(const blink::WebFormControlElement& element);
// Shows the autofill suggestions for |element|.
// This call is asynchronous and may or may not lead to the showing of a
@@ -140,7 +146,7 @@ class AutofillAgent : public content::RenderViewObserver,
// |datalist_only| specifies whether all of <datalist> suggestions and no
// autofill suggestions are shown. |autofill_on_empty_values| and
// |requires_caret_at_end| are ignored if |datalist_only| is true.
- void ShowSuggestions(const blink::WebInputElement& element,
+ void ShowSuggestions(const blink::WebFormControlElement& element,
bool autofill_on_empty_values,
bool requires_caret_at_end,
bool display_warning_if_disabled,
@@ -148,7 +154,7 @@ class AutofillAgent : public content::RenderViewObserver,
// Queries the browser for Autocomplete and Autofill suggestions for the given
// |element|.
- void QueryAutofillSuggestions(const blink::WebInputElement& element,
+ void QueryAutofillSuggestions(const blink::WebFormControlElement& element,
bool display_warning_if_disabled,
bool datalist_only);
@@ -186,7 +192,7 @@ class AutofillAgent : public content::RenderViewObserver,
int autofill_query_id_;
// The element corresponding to the last request sent for form field Autofill.
- blink::WebInputElement element_;
+ blink::WebFormControlElement element_;
// The form element currently requesting an interactive autocomplete.
blink::WebFormElement in_flight_request_form_;

Powered by Google App Engine
This is Rietveld 408576698