Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1400923003: media: Use libyuv::CopyPlane instead of memcpy. (Closed)

Created:
5 years, 2 months ago by Daniele Castagna
Modified:
5 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Use libyuv::CopyPlane instead of memcpy. libyuv::CopyPlane uses some low level optmization that memcpy doesn't have. This patch replaces the memcpy used when copying video frames to I420 GpuMemoryBuffers with libyuv::CopyPlane. BUG= Committed: https://crrev.com/302545262c4cacaf9224567e7796a12194d247fd Cr-Commit-Position: refs/heads/master@{#353898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M media/video/gpu_memory_buffer_video_frame_pool.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Daniele Castagna
As you suggested. I didn't notice any improvement on my linux box though.
5 years, 2 months ago (2015-10-13 20:27:43 UTC) #2
fbarchard
lgtm Its not a huge difference, but CopyPlane runs a little faster. It has 2 ...
5 years, 2 months ago (2015-10-13 22:34:40 UTC) #3
mcasas
lgtm
5 years, 2 months ago (2015-10-13 22:40:26 UTC) #4
Daniele Castagna
Thank you fbarchard@ for the really detailed answer! Adding sandersd@ for owner approval.
5 years, 2 months ago (2015-10-13 22:49:07 UTC) #6
sandersd (OOO until July 31)
RS LGTM.
5 years, 2 months ago (2015-10-13 23:00:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400923003/1
5 years, 2 months ago (2015-10-13 23:10:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 23:20:07 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 23:21:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/302545262c4cacaf9224567e7796a12194d247fd
Cr-Commit-Position: refs/heads/master@{#353898}

Powered by Google App Engine
This is Rietveld 408576698