Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

Issue 1400903002: Data reduction proxy enabled/disabled UMA for all platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed tbansal1 comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
index c6d697458acde038a310216756790198aa0c42ac..45d4f1c6eb49e01defb8c664c2df3036017da216 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
@@ -55,6 +55,15 @@ enum LoFiImplicitOptOutAction {
LO_FI_OPT_OUT_ACTION_INDEX_BOUNDARY,
};
+// Values of the UMA DataReductionProxy.EnabledState histogram.
+// This enum must remain synchronized with DataReductionProxyEnabledState
+// in metrics/histograms/histograms.xml.
+enum DataReductionSettingsEnabledAction {
+ DATA_REDUCTION_SETTINGS_ACTION_OFF_TO_ON = 0,
+ DATA_REDUCTION_SETTINGS_ACTION_ON_TO_OFF,
+ DATA_REDUCTION_SETTINGS_ACTION_BOUNDARY,
+};
+
// Central point for configuring the data reduction proxy.
// This object lives on the UI thread and all of its methods are expected to
// be called from there.
@@ -236,6 +245,8 @@ class DataReductionProxySettings : public DataReductionProxyServiceObserver {
TestLoFiImplicitOptOutHistograms);
FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,
TestLoFiSessionStateHistograms);
+ FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,
+ TestSettingsEnabledStateHistograms);
// Override of DataReductionProxyService::Observer.
void OnServiceInitialized() override;
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698