tools/metrics/histograms/histograms.xml - Issue 1400903002: Data reduction proxy enabled/disabled UMA for all platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1400903002: Data reduction proxy enabled/disabled UMA for all platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix for trybot components_unittests failure Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index cf6d33a699a0a7e4cf3bbd1b8bf2b6fd1f63b01e..65e3749d387f4b1c946fd725cd79f4b77409e78e 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -5790,6 +5790,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="DataReductionProxy.EnabledState"

+ enum="DataReductionProxyEnabledState">

+ <owner>bengr@chromium.org</owner>

+ <owner>rajendrant@chromium.org</owner>

+ <summary>

+ Samples of user interactions with the Data Saver settings menu across all

+ platforms(android, IOS, desktop extension). Data is collected whenever user

sclittle 2015/10/09 20:52:48 nit: add space between "platforms" and "("

Raj 2015/10/10 01:51:47 Done.

+ toggles the ON/OFF switch in the settings menu for reducing data usage.

+ For desktop, Off-to-On histogram count will increment when the data saver

+ extension is installed as well.

+ </summary>

+</histogram>

<owner>xingx@chromium.org</owner>

<owner>bolian@chromium.org</owner>

@@ -54896,6 +54910,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</enum>

+<enum name="DataReductionProxyEnabledState" type="int">

+ <int value="0" label="Turned On"/>

sclittle 2015/10/09 20:52:48 nit: Just for consistency, could you label these v

Raj 2015/10/10 01:51:47 Done.

+ <int value="1" label="Turned Off"/>

+</enum>