Data reduction proxy enabled/disabled UMA for all platforms

components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
 
 #include "base/command_line.h"
 #include "base/md5.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_samples.h"
@@ skipping 610 matching lines @@
   test_context_->RunUntilIdle();
   histogram_tester.ExpectBucketCount(
       kUMALoFiSessionState,
       DataReductionProxyService::LO_FI_SESSION_STATE_NOT_USED, 2);
 
   // Total count should be equal to the number of sessions.
   histogram_tester.ExpectTotalCount(
       kUMALoFiSessionState, settings_->lo_fi_consecutive_session_disables_ + 3);
 }
 
+TEST_F(DataReductionProxySettingsTest, TestSettingsEnabledStateHistograms) {
+  const char kUMAEnabledState[] = "DataReductionProxy.EnabledState";
+  base::HistogramTester histogram_tester;
+
+  settings_->InitPrefMembers();
+  settings_->data_reduction_proxy_service_->SetIOData(
+      test_context_->io_data()->GetWeakPtr());
+
+  // No settings state histograms should be recorded during startup
+  test_context_->RunUntilIdle();
+  scoped_ptr<base::HistogramSamples> samples(
+      histogram_tester.GetHistogramSamplesSinceCreation(kUMAEnabledState));
+  EXPECT_EQ(0, samples->TotalCount());

[sclittle, 2015/10/09 20:52:48]

Could this be replaced with:

histogram_tester.ExpectTotalCount(kUMAEnabledState, 0);

You could then remove the samples variable.

[Raj, 2015/10/10 01:51:47]

Done.

+
+  settings_->SetDataReductionProxyEnabled(true);
+  test_context_->RunUntilIdle();
+  histogram_tester.ExpectBucketCount(
+      kUMAEnabledState, DATA_REDUCTION_SETTINGS_ACTION_OFF_TO_ON, 1);
+  histogram_tester.ExpectBucketCount(
+      kUMAEnabledState, DATA_REDUCTION_SETTINGS_ACTION_ON_TO_OFF, 0);
+
+  settings_->SetDataReductionProxyEnabled(false);
+  test_context_->RunUntilIdle();
+  histogram_tester.ExpectBucketCount(
+      kUMAEnabledState, DATA_REDUCTION_SETTINGS_ACTION_OFF_TO_ON, 1);
+  histogram_tester.ExpectBucketCount(
+      kUMAEnabledState, DATA_REDUCTION_SETTINGS_ACTION_ON_TO_OFF, 1);
+}
+
 TEST_F(DataReductionProxySettingsTest, TestGetDailyContentLengths) {
   ContentLengthList result =
       settings_->GetDailyContentLengths(prefs::kDailyHttpOriginalContentLength);
 
   ASSERT_FALSE(result.empty());
   ASSERT_EQ(kNumDaysInHistory, result.size());
 
   for (size_t i = 0; i < kNumDaysInHistory; ++i) {
     long expected_length =
         static_cast<long>((kNumDaysInHistory - 1 - i) * 2);
@@ skipping 77 matching lines @@
                        SyntheticFieldTrialRegistrationCallback,
                    base::Unretained(this)));
 
     net::ProxyServer origin =
         test_context_->config()->test_params()->proxies_for_http().front();
     EXPECT_EQ(tests[i].enable_quic, origin.is_quic()) << i;
   }
 }
 
 }  // namespace data_reduction_proxy