Data reduction proxy enabled/disabled UMA for all platforms

components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_SETTINGS_H_
 #define COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_SETTINGS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 37 matching lines @@
 // This enum must remain synchronized with
 // DataReductionProxyLoFiImplicitOptOutAction in
 // metrics/histograms/histograms.xml.
 enum LoFiImplicitOptOutAction {
   LO_FI_OPT_OUT_ACTION_DISABLED_FOR_SESSION = 0,
   LO_FI_OPT_OUT_ACTION_DISABLED_UNTIL_NEXT_EPOCH,
   LO_FI_OPT_OUT_ACTION_NEXT_EPOCH,
   LO_FI_OPT_OUT_ACTION_INDEX_BOUNDARY,
 };
 
+// Values of the UMA DataReductionProxy.EnabledState histogram.
+// This enum must remain synchronized with
+// DataReductionProxyEnabledState in
+// metrics/histograms/histograms.xml.
+enum DataReductionSettingsEnabledAction {
+  DATA_REDUCTION_SETTINGS_ACTION_OFF_TO_ON = 0,
+  DATA_REDUCTION_SETTINGS_ACTION_ON_TO_OFF,
+  DATA_REDUCTION_SETTINGS_ACTION_BOUNDARY,
+};
+
 // Central point for configuring the data reduction proxy.
 // This object lives on the UI thread and all of its methods are expected to
 // be called from there.
 // TODO(marq): Convert this to be a KeyedService with an
 // associated factory class, and refactor the Java call sites accordingly.
 class DataReductionProxySettings : public DataReductionProxyServiceObserver {
  public:
   typedef base::Callback<bool(const std::string&, const std::string&)>
       SyntheticFieldTrialRegistrationCallback;
 
@@ skipping 130 matching lines @@
 
   // Metrics method. Subclasses should override if they wish to provide
   // alternatives.
   virtual void RecordDataReductionInit();
 
   // Virtualized for mocking. Records UMA specifying whether the proxy was
   // enabled or disabled at startup.
   virtual void RecordStartupState(
       data_reduction_proxy::ProxyStartupState state);
 
+  // Virtualized for mocking. Records UMA whenever user toggles the
+  // ON/OFF in settings UI
+  virtual void RecordSettingsEnabledState(
+      data_reduction_proxy::DataReductionSettingsEnabledAction action);
+
  private:
   friend class DataReductionProxySettingsTestBase;
   friend class DataReductionProxySettingsTest;
   friend class DataReductionProxyTestContext;
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,
                            TestResetDataReductionStatistics);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,
                            TestIsProxyEnabledOrManaged);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,
                            TestCanUseDataReductionProxy);
@@ skipping 11 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,
                            CheckInitMetricsWhenNotAllowed);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,
                            TestLoFiImplicitOptOutClicksPerSession);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,
                            TestLoFiImplicitOptOutConsecutiveSessions);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,
                            TestLoFiImplicitOptOutHistograms);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,
                            TestLoFiSessionStateHistograms);
+  FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsTest,

[sclittle, 2015/10/09 20:52:48]

I don't think you need this FRIEND_TEST_ALL_PREFIXES, since your test isn't
trying to call any protected or private methods of DataReductionProxySettings.

[Raj, 2015/10/10 01:51:47]

TestSettingsEnabledStateHistograms() calls settings_->InitPrefMembers() which
requires it to be friend

+                           TestSettingsEnabledStateHistograms);
 
   // Override of DataReductionProxyService::Observer.
   void OnServiceInitialized() override;
 
   // Registers the trial "SyntheticDataReductionProxySetting" with the group
   // "Enabled" or "Disabled". Indicates whether the proxy is turned on or not.
   void RegisterDataReductionProxyFieldTrial();
 
   // Registers the trial "SyntheticDataReductionProxyLoFiSetting" with the group
   // "Enabled" or "Disabled". Indicates whether Lo-Fi is turned on or not.
@@ skipping 53 matching lines @@
   SyntheticFieldTrialRegistrationCallback register_synthetic_field_trial_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxySettings);
 };
 
 }  // namespace data_reduction_proxy
 
 #endif  // COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_SETTINGS_H_