Data reduction proxy enabled/disabled UMA for all platforms

components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/prefs/pref_member.h"
@@ skipping 236 matching lines @@
   // related prefs.
   if (!prefs)
     return;
   // TODO(marq): Consider moving this so stats are wiped the first time the
   // proxy settings are actually (not maybe) turned on.
   if (spdy_proxy_auth_enabled_.GetValue() &&
       !prefs->GetBoolean(prefs::kDataReductionProxyWasEnabledBefore)) {
     prefs->SetBoolean(prefs::kDataReductionProxyWasEnabledBefore, true);
     ResetDataReductionStatistics();
   }
+  if (!at_startup) {
+    if (IsDataReductionProxyEnabled())
+      RecordSettingsEnabledState(DATA_REDUCTION_SETTINGS_ACTION_OFF_TO_ON);
+    else
+      RecordSettingsEnabledState(DATA_REDUCTION_SETTINGS_ACTION_ON_TO_OFF);
+  }
   // Configure use of the data reduction proxy if it is enabled.
   if (at_startup && !data_reduction_proxy_service_->Initialized())
     deferred_initialization_ = true;
   else
     UpdateIOData(at_startup);
 }
 
 DataReductionProxyEventStore* DataReductionProxySettings::GetEventStore()
     const {
   if (data_reduction_proxy_service_)
@@ skipping 15 matching lines @@
 
   RecordStartupState(state);
 }
 
 void DataReductionProxySettings::RecordStartupState(ProxyStartupState state) {
   UMA_HISTOGRAM_ENUMERATION(kUMAProxyStartupStateHistogram,
                             state,
                             PROXY_STARTUP_STATE_COUNT);
 }
 
+void DataReductionProxySettings::RecordSettingsEnabledState(

[sclittle, 2015/10/09 20:52:48]

It doesn't look like this function needs to be a method of
DataReductionProxySettings - could you move this function into the anonymous
namespace at the top of this file? You can remove the method definition in the
.h file as well.

[Raj, 2015/10/10 01:51:47]

Done.

+    DataReductionSettingsEnabledAction action) {
+  UMA_HISTOGRAM_ENUMERATION("DataReductionProxy.EnabledState", action,
+                            DATA_REDUCTION_SETTINGS_ACTION_BOUNDARY);
+}
+
 void DataReductionProxySettings::RecordLoFiImplicitOptOutAction(
     LoFiImplicitOptOutAction action) const {
   net::NetworkChangeNotifier::ConnectionType connection_type =
       net::NetworkChangeNotifier::GetConnectionType();
 
   switch (connection_type) {
     case net::NetworkChangeNotifier::CONNECTION_UNKNOWN:
       UMA_HISTOGRAM_ENUMERATION(
           "DataReductionProxy.LoFi.ImplicitOptOutAction.Unknown", action,
           LO_FI_OPT_OUT_ACTION_INDEX_BOUNDARY);
@@ skipping 53 matching lines @@
     int64* received_content_length,
     int64* last_update_time) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(data_reduction_proxy_service_->compression_stats());
 
   data_reduction_proxy_service_->compression_stats()->GetContentLengths(
       days, original_content_length, received_content_length, last_update_time);
 }
 
 }  // namespace data_reduction_proxy