Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14008005: Move proto files back into chrome/browser/policy/proto (Closed)

Created:
7 years, 8 months ago by Mattias Nissler (ping if slow)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move proto files back into chrome/browser/policy/proto The chrome/browser/policy/proto.git repo was broken due to the moves, and pulling proto files from several paths in the Chrome tree into the Chrome OS build adds complexity. Hence, move back the proto files to chrome/browser/policy/proto/{cloud,chromeos}. BUG=None TEST=Compiles and passes tests. TBR=sky@chromium.org, nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -1038 lines) Patch
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_validator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 1 chunk +0 lines, -320 lines 0 comments Download
D chrome/browser/chromeos/policy/proto/install_attributes.proto View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_policy_disk_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_policy_token_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_cache_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_validator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_updater_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/device_management_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/mock_cloud_policy_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/mock_device_management_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/policy_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/policy_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/cloud/proto/chrome_extension_policy.proto View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/policy/cloud/proto/device_management_backend.proto View 1 chunk +0 lines, -538 lines 0 comments Download
D chrome/browser/policy/cloud/proto/device_management_local.proto View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/policy/cloud/test_request_interceptor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/policy/proto/chromeos/chrome_device_policy.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/proto/chromeos/install_attributes.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/proto/cloud/chrome_extension_policy.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/proto/cloud/device_management_backend.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/proto/cloud/device_management_local.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/policy/test/local_policy_test_server.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Please review! Note that is a purely mechanical change for moving the .proto files, mostly ...
7 years, 8 months ago (2013-04-26 10:16:44 UTC) #1
pastarmovj
lgtm
7 years, 8 months ago (2013-04-26 10:43:46 UTC) #2
Mattias Nissler (ping if slow)
sky and nkostylev to TBR for the gyp changes and OWNERS coverage of the files ...
7 years, 8 months ago (2013-04-26 11:13:21 UTC) #3
Mattias Nissler (ping if slow)
7 years, 8 months ago (2013-04-26 11:13:47 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r196698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698