Issue 140078: Move the titlebar background drawing from the titlebar to the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140078: Move the titlebar background drawing from the titlebar to the (Closed)

Created:
11 years, 6 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Move the titlebar background drawing from the titlebar to the browser window. This fixes a visual bug where the border looked disconnected with the background. This matches what Windows does. BUG=14884

Patch Set 1 #

Patch Set 2 : rebase #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -34 lines)			Patch
M	chrome/browser/gtk/browser_titlebar.h	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/gtk/browser_titlebar.cc	View	3 chunks	+0 lines, -24 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages