Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 140078: Move the titlebar background drawing from the titlebar to the (Closed)

Created:
11 years, 6 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move the titlebar background drawing from the titlebar to the browser window. This fixes a visual bug where the border looked disconnected with the background. This matches what Windows does. BUG=14884

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -34 lines) Patch
M chrome/browser/gtk/browser_titlebar.h View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/gtk/browser_titlebar.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
11 years, 6 months ago (2009-06-22 19:10:09 UTC) #1
Evan Martin
11 years, 6 months ago (2009-06-22 19:14:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698