Issue 1400773002: Fix a bad refactoring error from commit 8a9ce57.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1400773002: Fix a bad refactoring error from commit 8a9ce57. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	core/src/fxcodec/jbig2/JBig2_HuffmanTable.cpp	View		2 chunks	+3 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

Whoops, in the goto CL, the loop started at CURLEN = 1.

5 years, 2 months ago (2015-10-09 02:15:33 UTC) #2

Tom Sepez

Yeah, and I signed off on it too. I wonder about my eyesight. LGTM.

5 years, 2 months ago (2015-10-09 16:55:49 UTC) #3

Lei Zhang

5 years, 2 months ago (2015-10-09 17:04:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c9952e66c588aad6a5996796fb0c96b202e6de0a (presubmit successful).