Issue 140076: GTK: Polish HTTP Auth UI. Adds standard border and word wraps the label.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140076: GTK: Polish HTTP Auth UI. Adds standard border and word wraps the label. (Closed)

Created:
11 years, 6 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, James Hawkins, Evan Martin, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

GTK: Polish HTTP Auth UI. Adds standard border and word wraps the label. http://crbug.com/11512 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18930

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	chrome/browser/gtk/constrained_window_gtk.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
	M	chrome/browser/login_prompt_gtk.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

tony

LGTM2. I think evanm said that the inset border looked funny. Not sure what your ...

11 years, 6 months ago (2009-06-22 18:36:33 UTC) #3

Evan Martin

11 years, 6 months ago (2009-06-22 18:46:15 UTC) #4

GTK_SHADOW_OUT would look better, I think.  Less noise around the edge of the
window
 *shrug*