[Interpreter] Add array literal support.

test/cctest/interpreter/test-interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/execution.h"
 #include "src/handles.h"
 #include "src/interpreter/bytecode-array-builder.h"
 #include "src/interpreter/interpreter.h"
@@ skipping 84 matching lines @@
 
   static Handle<Object> NewObject(const char* script) {
     return v8::Utils::OpenHandle(*CompileRun(script));
   }
 
   static Handle<String> GetName(Isolate* isolate, const char* name) {
     Handle<String> result = isolate->factory()->NewStringFromAsciiChecked(name);
     return isolate->factory()->string_table()->LookupString(isolate, result);
   }
 
+  static std::string SourceForBody(const char* body) {
+    return "function " + function_name() + "() {\n" + std::string(body) + "\n}";
+  }
+
   static std::string function_name() {
     return std::string(kFunctionName);
   }
 
  private:
   Isolate* isolate_;
   const char* source_;
   MaybeHandle<BytecodeArray> bytecode_;
   MaybeHandle<TypeFeedbackVector> feedback_vector_;
 
@@ skipping 1448 matching lines @@
       "function " + InterpreterTester::function_name() + "(a) {\n"
       "  return (function(x){ return x + 2; })(a);\n"
       "}");
   InterpreterTester tester(handles.main_isolate(), source.c_str());
   auto callable = tester.GetCallable<Handle<Object>>();
 
   Handle<i::Object> return_val = callable(
       Handle<Smi>(Smi::FromInt(3), handles.main_isolate())).ToHandleChecked();
   CHECK_EQ(Smi::cast(*return_val), Smi::FromInt(5));
 }
+
+
+TEST(InterpreterArrayLiterals) {
+  HandleAndZoneScope handles;
+  i::Isolate* isolate = handles.main_isolate();
+  i::Factory* factory = isolate->factory();
+
+  std::pair<const char*, Handle<Object>> literals[5] = {
+      std::make_pair("return [1, 3, 2][1];\n",

[oth, 2015/10/09 13:07:34]

Coverage for the empty array case would be good.

[rmcilroy, 2015/10/09 13:14:02]

Good plan, done.

+                     Handle<Object>(Smi::FromInt(3), isolate)),
+      std::make_pair("return ['a', 'b', 'c'][2];\n",
+                     factory->NewStringFromStaticChars("c")),
+      std::make_pair("var a = 100; return [a, a + 1, a + 2, a + 3][2];\n",
+                     Handle<Object>(Smi::FromInt(102), isolate)),
+      std::make_pair("return [[1, 2, 3], ['a', 'b', 'c']][1][0];\n",
+                     factory->NewStringFromStaticChars("a")),
+      std::make_pair("var t = 't'; return [[t, t + 'est'], [1 + t]][0][1];\n",
+                     factory->NewStringFromStaticChars("test"))
+  };
+
+  for (size_t i = 0; i < arraysize(literals); i++) {
+    std::string source(InterpreterTester::SourceForBody(literals[i].first));
+    InterpreterTester tester(handles.main_isolate(), source.c_str());
+    auto callable = tester.GetCallable<>();
+
+    Handle<i::Object> return_value = callable().ToHandleChecked();
+    CHECK(return_value->SameValue(*literals[i].second));
+  }
+}