content/browser/browser_plugin/browser_plugin_guest.h - Issue 140073002: <webview>: navigating to WebStore should fire a loadabort instead of crashing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 140073002: <webview>: navigating to WebStore should fire a loadabort instead of crashing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with ToT Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/shim/main.js ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index 3e2d98a2f5c7147d0f9c858cb0ba5734337c62b7..0ed0e08a3f531121c871ee8831cfc14c14f09e0b 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -334,11 +334,9 @@ class CONTENT_EXPORT BrowserPluginGuest

// has been attached to a BrowserPlugin. Once the first navigation commits, we

// no longer track this information.

struct NewWindowInfo {

- bool changed;

GURL url;

std::string name;

NewWindowInfo(const GURL& url, const std::string& name) :

- changed(false),

url(url),

name(name) {}

};