Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Issue 1400713002: ipc: Add a member to IPC::Message::Header on Windows. (Closed)

Created:
5 years, 2 months ago by erikchen
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Add a member to IPC::Message::Header on Windows. According to my most recent debugging experiments, the root cause of the crashes that happened the first time I tried to make this change have magically disappeared. See the bug for more details. BUG=527588 Committed: https://crrev.com/c32bea67c022c6c385463f0eec027f18b2915300 Cr-Commit-Position: refs/heads/master@{#354889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ipc/ipc_message.h View 2 chunks +2 lines, -1 line 0 comments Download
M ipc/ipc_message.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
erikchen
tsepez: Please review.
5 years, 2 months ago (2015-10-08 23:44:10 UTC) #2
Tom Sepez
lgtm
5 years, 2 months ago (2015-10-09 17:05:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400713002/1
5 years, 2 months ago (2015-10-09 17:33:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/93737)
5 years, 2 months ago (2015-10-09 18:14:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400713002/1
5 years, 2 months ago (2015-10-19 21:14:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 22:23:39 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c32bea67c022c6c385463f0eec027f18b2915300 Cr-Commit-Position: refs/heads/master@{#354889}
5 years, 2 months ago (2015-10-19 22:24:50 UTC) #11
erikchen
5 years, 2 months ago (2015-10-20 17:21:22 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1414293002/ by erikchen@chromium.org.

The reason for reverting is: Likely causes crashes:
https://code.google.com/p/chromium/issues/detail?id=527588#c57.

Powered by Google App Engine
This is Rietveld 408576698