Pepper: Autogenerate thunk for PPB_URL_Loader.

Pepper: Autogenerate thunk for PPB_URL_Loader.

This requires another annotation:
  "always_set_output_parameters"

This annotation ensures that the thunk implementation will zero-out the value of all output parameters on failure.

Tested:
  Built chrome and browser_tests.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194613

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194915

[teravest, 2013-04-17 15:42:14]

I'll send another patch later to remove duplication in idl_thunk.py.

Unfortunately, cleaning that up is going to touch a ton of thunk files, so I
figured I'd do that in a separate change so it's easier to review.

[dmichael (off chromium), 2013-04-17 16:01:11]

One issue, o/w lgtm

https://codereview.chromium.org/14007010/diff/2001/ppapi/thunk/ppb_url_loader...
File ppapi/thunk/ppb_url_loader_thunk.cc (right):

https://codereview.chromium.org/14007010/diff/2001/ppapi/thunk/ppb_url_loader...
ppapi/thunk/ppb_url_loader_thunk.cc:61: memset(bytes_sent, 0, sizeof(int64_t));
It would be better to generate: "sizeof(bytes_sent)"

[teravest, 2013-04-17 16:09:41]

On Wed, Apr 17, 2013 at 10:01 AM,  <dmichael@chromium.org> wrote:
> One issue, o/w lgtm
>
>
>
https://codereview.chromium.org/14007010/diff/2001/ppapi/thunk/ppb_url_loader...
> File ppapi/thunk/ppb_url_loader_thunk.cc (right):
>
>
https://codereview.chromium.org/14007010/diff/2001/ppapi/thunk/ppb_url_loader...
> ppapi/thunk/ppb_url_loader_thunk.cc:61: memset(bytes_sent, 0,
> sizeof(int64_t));
> It would be better to generate: "sizeof(bytes_sent)"

Done.

>
> https://codereview.chromium.org/14007010/

[teravest, 2013-04-17 16:54:39]

Committed patchset #4 manually as r194613 (presubmit successful).

[teravest, 2013-04-18 14:04:15]

Committed patchset #5 manually as r194915 (presubmit successful).