src/heap-profiler.cc - Issue 14007008: New GC APIs, try 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-profiler.cc

Issue 14007008: New GC APIs, try 2. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Moving funcs & code review. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap-profiler.cc

diff --git a/src/heap-profiler.cc b/src/heap-profiler.cc

index 5c1badf9c90f16851255bc2edd03e1c170755283..4f6fdb1122d8c916e9d4f54b1ba96eadd994fe33 100644

--- a/src/heap-profiler.cc

+++ b/src/heap-profiler.cc

@@ -140,5 +140,10 @@ void HeapProfiler::ObjectMoveEvent(Address from, Address to) {

snapshots_->ObjectMoveEvent(from, to);

}

+void HeapProfiler::SetRetainedObjectInfo(UniqueId id,

+ RetainedObjectInfo* info) {

+ // TODO(yurus, marja): Don't route this information through GlobalHandles.

+ heap()->isolate()->global_handles()->SetRetainedObjectInfo(id, info);

} } // namespace v8::internal