cc: Don't do produce/consume on the texture id given in VideoFrame.

cc: Don't do produce/consume on the texture id given in VideoFrame.

This texture id is used for hardware readback to webgl, so producing
the texture id breaks that path.

Instead, add a hardware_resource ResourceId to pass along with the
video frame resources to the VideoLayerImpl. This is a resource id
wrapping the hardware decoder texture. Once we have shared mailboxes
this can be removed, and we can just pass the Mailbox from the
VideoFrame to the video layer.

R=enne,piman
BUG=179729
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194108

[piman, 2013-04-12 22:33:28]

lgtm

[commit-bot: I haz the power, 2013-04-12 22:36:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/14007004/4001

[no sievers, 2013-04-13 01:14:30]

https://codereview.chromium.org/14007004/diff/4001/cc/resources/video_resourc...
File cc/resources/video_resource_updater.cc (left):

https://codereview.chromium.org/14007004/diff/4001/cc/resources/video_resourc...
cc/resources/video_resource_updater.cc:352: GLC(context,
context->bindTexture(GL_TEXTURE_2D, texture_id));
Hey when you reland, be sure to use the right texture target in all
glBindTexture(), glProduceTexture(), glConsumeTexture() calls. That is,
GL_TEXTURE_EXTERNAL_OES, GL_TEXTURE_RECTANGLE_ARB where necessary :)

[commit-bot: I haz the power, 2013-04-13 05:07:03]

List of reviewers changed. sievers@chromium.org did a drive-by without LGTM'ing!

[danakj, 2013-04-13 16:47:24]

https://codereview.chromium.org/14007004/diff/4001/cc/resources/video_resourc...
File cc/resources/video_resource_updater.cc (left):

https://codereview.chromium.org/14007004/diff/4001/cc/resources/video_resourc...
cc/resources/video_resource_updater.cc:352: GLC(context,
context->bindTexture(GL_TEXTURE_2D, texture_id));
On 2013/04/13 01:14:30, Daniel Sievers wrote:
> Hey when you reland, be sure to use the right texture target in all
> glBindTexture(), glProduceTexture(), glConsumeTexture() calls. That is,
> GL_TEXTURE_EXTERNAL_OES, GL_TEXTURE_RECTANGLE_ARB where necessary :)

Ohh right. Thanks, I shall pay attention to that

[commit-bot: I haz the power, 2013-04-13 16:47:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/14007004/4001

[commit-bot: I haz the power, 2013-04-13 16:47:56]

Change committed as 194108