Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1400633002: Revert of Pass --images '' to nanobench to disable image benchmarking. (Closed)

Created:
5 years, 2 months ago by scroggo
Modified:
5 years, 2 months ago
Reviewers:
mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Pass --images '' to nanobench to disable image benchmarking. (patchset #1 id:1 of https://codereview.chromium.org/1381703003/ ) Reason for revert: I have attempted to fix the problems that caused running nanobench with images to fail, so testing to see if they are in fact fixed. Original issue's description: > Pass --images '' to nanobench to disable image benchmarking. > > Enabling image benchmarking has caused most nanobench runs to fail, > both Debug and Release. > > BUG=skia:3418 > NOTREECHECKS=true > TBR=scroggo@google.com > > Committed: https://skia.googlesource.com/skia/+/1f7039c6c5f0f118b629994b0bac255345e5abd6 BUG=skia:3418 Committed: https://skia.googlesource.com/skia/+/c2e59caa0a466040f4b4f08cb5604c86b2615efa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M tools/nanobench_flags.json View 6 chunks +0 lines, -6 lines 0 comments Download
M tools/nanobench_flags.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
scroggo
Created Revert of Pass --images '' to nanobench to disable image benchmarking.
5 years, 2 months ago (2015-10-08 20:04:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400633002/1
5 years, 2 months ago (2015-10-08 20:05:08 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 20:05:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400633002/1
5 years, 2 months ago (2015-10-08 20:05:47 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 20:17:49 UTC) #10
mtklein_C
lgtm
5 years, 2 months ago (2015-10-08 21:08:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400633002/1
5 years, 2 months ago (2015-10-08 21:08:49 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/c2e59caa0a466040f4b4f08cb5604c86b2615efa
5 years, 2 months ago (2015-10-08 21:09:46 UTC) #14
scroggo
5 years, 2 months ago (2015-10-08 21:44:35 UTC) #15
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1396843003/ by scroggo@google.com.

The reason for reverting is: Still breaking. e.g.

http://build.chromium.org/p/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX...

http://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Nex....

Powered by Google App Engine
This is Rietveld 408576698