Issue 140053005: Use LocalStyleChange for updating :-webkit-drag.

Issue 140053005: Use LocalStyleChange for updating :-webkit-drag. (Closed)

Created:
6 years, 10 months ago by rune

Modified:
6 years, 10 months ago

Reviewers:
ojan

CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, rune+blink, esprehn, eseidel

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use LocalStyleChange for updating :-webkit-drag. If you don't have childrenAffectedByDrag, use LocalStyleChange instead of SubtreeStyleChange to avoid unnecessary recalc of the whole subtree. R=ojan BUG=341831 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166746

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed review issue. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -2 lines)			Patch
M	Source/core/core.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	Source/core/css/DragUpdateTest.cpp	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm https://codereview.chromium.org/140053005/diff/1/Source/core/css/DragUpdateTest.cpp File Source/core/css/DragUpdateTest.cpp (right): https://codereview.chromium.org/140053005/diff/1/Source/core/css/DragUpdateTest.cpp#newcode32 Source/core/css/DragUpdateTest.cpp:32: document->view()->updateLayoutAndStyleIfNeededRecursive(); Not sure it really matters, but I ...

6 years, 10 months ago (2014-02-07 20:52:46 UTC) #2

rune

https://codereview.chromium.org/140053005/diff/1/Source/core/css/DragUpdateTest.cpp File Source/core/css/DragUpdateTest.cpp (right): https://codereview.chromium.org/140053005/diff/1/Source/core/css/DragUpdateTest.cpp#newcode32 Source/core/css/DragUpdateTest.cpp:32: document->view()->updateLayoutAndStyleIfNeededRecursive(); On 2014/02/07 20:52:46, ojan wrote: > Not sure ...

6 years, 10 months ago (2014-02-07 21:53:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/140053005/60001

6 years, 10 months ago (2014-02-07 21:53:46 UTC) #5

Message was sent while issue was closed.

Change committed as 166746

Expand Messages | Collapse Messages