Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 140053002: move SkMessageBus::Get out of header (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
CC:
skia-review_googlegroups.com, djsollen
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Move SkMessageBus::Get out of header, and retry crrev.com/106563002. BUG= Committed: http://code.google.com/p/skia/source/detail?r=13104

Patch Set 1 #

Patch Set 2 : obsolete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -17 lines) Patch
M src/core/SkMessageBus.h View 2 chunks +12 lines, -11 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/MessageBusTest.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 3 chunks +75 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
6 years, 11 months ago (2014-01-15 21:51:12 UTC) #1
bsalomon
On 2014/01/15 21:51:12, mtklein wrote: lgtm
6 years, 11 months ago (2014-01-15 22:05:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/140053002/40001
6 years, 11 months ago (2014-01-15 22:56:58 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 23:09:04 UTC) #4
Message was sent while issue was closed.
Change committed as 13104

Powered by Google App Engine
This is Rietveld 408576698