Issue 140053002: move SkMessageBus::Get out of header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140053002: move SkMessageBus::Get out of header (Closed)

Created:
6 years, 11 months ago by mtklein

Modified:
6 years, 11 months ago

Reviewers:
Kimmo Kinnunen, bsalomon

CC:
skia-review_googlegroups.com, djsollen

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Move SkMessageBus::Get out of header, and retry crrev.com/106563002. BUG= Committed: http://code.google.com/p/skia/source/detail?r=13104

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -17 lines)			Patch
M	src/core/SkMessageBus.h	View		2 chunks	+12 lines, -11 lines	0 comments	Download
M	src/gpu/GrResourceCache.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/MessageBusTest.cpp	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	tests/ResourceCacheTest.cpp	View	1	3 chunks	+75 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/140053002/40001

6 years, 11 months ago (2014-01-15 22:56:58 UTC) #3

Message was sent while issue was closed.

Change committed as 13104